Conversation
MajorLift
force-pushed
the
jongsun/feat/250828-make-generic-KnownCaipNamespacedChainId
branch
from
2a6ad40 to
65c5896
Compare
MajorLift
changed the title
KnownCaipNamespacedChainId generic upon Namespace type parameterKnownCaipNamespacedChainId generic over Namespace type parameter
MajorLift
deleted the
jongsun/feat/250828-make-generic-KnownCaipNamespacedChainId
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit refactors
KnownCaipNamespacedChainId(introduced in #258) into a generic type by adding aNamespacetype parameter. This allows the type to be narrowed down to chain IDs with a specific namespace.This is not a breaking change, as
Namespacedefaults to a type union of known CAIP namespaces. The type's previous behavior is preserved when its generic type parameter is omitted.